springup/cmc-sales
2
0
Fork 0
Code Issues 49 Pull requests Actions Packages Projects Releases Wiki Activity

Fixing bug where quote revisions would not set the user, fixing quotes not showing up if they don't have a valid user

Browse source
This commit is contained in:
Finley Ghosh 2025-12-07 21:18:35 +11:00
parent e11013bd9f
commit 2459df569e
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
go/internal/cmc/handlers/quotes/quotes.go
View file

@ -91,7 +91,7 @@ func (q ExpiringSoonQuoteRowWrapper) GetUsername() string {
if q.Username.Valid {
return q.Username.String
}
return "Unknown"
return "-"
}
func (q ExpiringSoonQuoteRowWrapper) GetUserEmail() string {
if q.UserEmail.Valid {
@ -115,7 +115,7 @@ func (q RecentlyExpiredQuoteRowWrapper) GetUsername() string {
if q.Username.Valid {
return q.Username.String
}
return "Unknown"
return "-"
}
func (q RecentlyExpiredQuoteRowWrapper) GetUserEmail() string {
if q.UserEmail.Valid {
@ -141,7 +141,7 @@ func (q ExpiringSoonQuoteOnDayRowWrapper) GetUsername() string {
if q.Username.Valid {
return q.Username.String
}
return "Unknown"
return "-"
}
func (q ExpiringSoonQuoteOnDayRowWrapper) GetUserEmail() string {
if q.UserEmail.Valid {

4
php/app/controllers/documents_controller.php
View file

@ -540,6 +540,10 @@ ENDINSTRUCTIONS;
$number_of_revisions = $this->Document->Quote->findCount('Quote.enquiry_id ='. $enquiryid);
$newDoc['Document']['revision'] = $number_of_revisions;
$newDoc['Document']['type'] = 'quote';
// user_id for the new revision will be the current user
$currentUser = $this->GetCurrentUser();
$newDoc['Document']['user_id'] = $currentUser['User']['id'];
$newDoc['DocPage'] = $document['DocPage'];